On 09.04.2008 01:12, [EMAIL PROTECTED] wrote:
Author: minfrin
Date: Tue Apr 8 16:12:12 2008
New Revision: 646126
URL: http://svn.apache.org/viewvc?rev=646126&view=rev
Log:
Insert prototypes to remove compiler warnings. [Joe Orton]
Modified:
httpd/httpd/trunk/modules/session/mod_session.c
httpd/httpd/trunk/modules/session/mod_session_cookie.c
httpd/httpd/trunk/modules/session/mod_session_crypto.c
httpd/httpd/trunk/modules/session/mod_session_dbd.c
Modified: httpd/httpd/trunk/modules/session/mod_session.c
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/session/mod_session.c?rev=646126&r1=646125&r2=646126&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/session/mod_session.c (original)
+++ httpd/httpd/trunk/modules/session/mod_session.c Tue Apr 8 16:12:12 2008
@@ -40,13 +40,18 @@
(request_rec * r, session_rec * z), (r, z), OK, DECLINED)
AP_IMPLEMENT_HOOK_RUN_ALL(int, session_decode,
(request_rec * r, session_rec * z), (r, z), OK, DECLINED)
+
+AP_DECLARE(int) ap_session_identity_encode(request_rec * r, session_rec * z);
+AP_DECLARE(int) ap_session_identity_decode(request_rec * r, session_rec * z);
+AP_DECLARE(int) ap_session_fixups(request_rec * r);
+
Two questions:
1. Why using AP_DECLARE for functions that seem to be clearly used as functions
local to this file. IMHO static int would be better.
2. Why using an ap_ prefix for a local function? IMHO only exported function
should get this prefix. Otherwise you might get confused reading the code
by assuming that these functions get exported.
BTW: This comment is valid for all session stuff.
Regards
Rüdiger
P.S.: Please add an appropriate [auto-props] config to your subversion client
config to avoid the eol-style mess we had recently in the future.
