Plüm, Rüdiger, VF-Group schrieb: >>> On 10/16/2008 12:04 PM, Rainer Jung wrote: >>>> Ruediger Pluem wrote: >>>>> While investigating PR46018 I came across the following in >>> acinclude.m4 >>>>> dnl Run header and version checks >>>>> saved_CPPFLAGS="$CPPFLAGS" >>>>> saved_LIBS="$LIBS" >>>>> if test "x$ap_ssltk_base" != "x"; then >>>>> APR_ADDTO(CPPFLAGS, [-I$ap_ssltk_base/include]) >>>>> APR_ADDTO(INCLUDES, [-I$ap_ssltk_base/include]) >>>>> APR_ADDTO(LDFLAGS, [-L$ap_ssltk_base/lib]) >>>>> >>>>> >>>>> Is there any reason why we only save / restore CPPFLAGS >>> and LIBS and >>>>> not INCLUDES and LDFLAGS which are also modified? >>>>> >>>>> The next thing I don't get is why we do not add >>> `$apr_config --libs` >>>>> to LIBS >>>>> any longer (since r669924). This causes -ldl to miss and thus the >>>>> checks to fail >>>>> (I guess only if there is no pkgconfig file). >>>> Yes, I ran into a similar issue, when compiling 2.2.10 >>> against static >>>> openssl libs on Solaris, having no pkgconfig. Then you need >>> to add -ldl, >>>> -lnsl, -lsocket during the configure tests, because >>> otherwise tehy fail. >>>> That was not necessary until 2.2.9. >>> Any further comments, ideas how to fix this? >> I added a possible fix to the PR >> (https://issues.apache.org/bugzilla/attachment.cgi?id=22826). >> Does somebody mind checking if this is the correct thing to do? > > Rainer does the patch fix your issues on Solaris?
The additional `$apr_config --libs` seems fine to fix the issue during configure itself. Saving INCLUDES and LDFLAGS break the build. Without saving, entries are added to EXTRA_INCLUDES and EXTRA_LDFLAGS in build/config_vars.mk. Those entries are needed to build ab and mod_ssl and to link them. For the linking issue one could instead of adding the SSL-specifix -L... to EXTRA_LDFLAGS add them to ab_LDADD and to MOD_SSL_LDADD: it seems not to be needed for anything else. Since both of those vars include SSL_LIBS, it could also go in there. The include flag is harder, since at the moment the build system does ot include a component specific include variable (like ab_INCADD or MOD_SSL_INCADD). So now we know, why INCLUDES and LDFLAGS where not saved in configure ;) I'll test once more without the save-related parts of the patch and let you know. Regards, Rainer
