On Oct 9, 2009, at 5:46 PM, Graham Leggett wrote:
Brian J. France wrote:

Depends.

Should a mod_dav_fs type module (like mod_dav_fs_database) update
r->filename so other modules like mod_dav_acl could use the filename
from the request_rec.
Or should mod_dav_acl use a hook function to get the pathname because
r->filename would not be set correctly since that is a path on disk in
the case of mod_dav_fs_database?

My patch (version 3) left the get_pathname hook with the assumption that
r->filename should not be used and instead a hook should be used.

Thanks for this, committed to httpd-trunk in r823703.


Graham,

  Could you commit this as well.

http://www.brianfrance.com/software/apache/dav/fixup.diff

It is a clean up of r823703, fixes bad struct declaration and changes comments on functions.

Thanks,

Brian

Reply via email to