On Mon, Dec 21, 2009 at 2:39 AM, "Plüm, Rüdiger, VF-Group" <[email protected]> wrote: > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On >> Behalf Of Nick Kew >> Sent: Montag, 21. Dezember 2009 10:36 >> To: [email protected] >> Subject: Re: svn commit: r892678 - in /httpd/httpd/trunk: >> CHANGES server/protocol.c >> >> >> On 21 Dec 2009, at 07:22, Ruediger Pluem wrote: >> >> > Why bytes_handled - 1 and not bytes_handled? > > Using bytes_handled - 1 breaks a lot of tests in the perl test framework. > Using bytes_handled instead fixes this. > Please reconsider and fix.
I am also slightly concerned about changing the behavoir of ap_rgetline_core in regards to embedded NULL bytes, since this is not just used by HTTP protocol handlers, it appears it could easily be used by other protocols... at a minimum I think there should be a comment in the header docs about this behavior change?
