On Mon, Mar 28, 2011 at 6:13 PM, William A. Rowe Jr. <[email protected]> wrote: > /* LDAP cache state information */ > typedef struct util_ldap_state_t { > ... > int connectionPoolTTL; > } util_ldap_state_t; > > > I'm continue to grow more worried that the state of ldap in httpd > and in apr enjoys very little granularity, oversight, or quality... > > 1. Hungarian? Forgot to eat breakfast that day? Out of bounds > per httpd style rules. > > 2. int? Really? This is assigned an apr_interval_time_t in its > config code. > > Please review and fix the style violations, and ensure that timeouts > are doing what they were meant to do. >
Thanks for the review, blockers above in r1086432 (and bugfix in r1086433) -- Eric Covener [email protected]
