On 3/28/2011 6:18 PM, Graham Leggett wrote: > > Looks like mod_ssl needs some similar cleanup, there are still style > violations in there, > not limited to the examples below. Now would be a good time to overhaul style.
Agreed; it's much harder (and less justifiable) to make these sorts of changes mid-maintenance after a 2.4.0 tag, especially since they are harder to follow/ignore than whitespace changes. +1 to whomever wants to do the very significant work of un-Hungarianizing mod_ssl at this juncture. The reason I never did this is because SSL uses some Hungarian notation itself, and at the interface boundary it's less worrying. But you are pointing out httpd'isms and apr'isms which shouldn't have been expressed that way. FWIW I come from that background myself :) But my examples in httpd are limited to the places in mod_isapi where we intersect with Win32 constructs, so it actually makes the code more legible to know 'that data' is over on the isapi side of the world, and this other data is rooted in and managed by httpd.
