Hi,
We are using Sentry (a C/C++ static analysis tool) to analyze
httpd on a nightly basis. Sentry found that a dead assignment
was recently introduced in the commit r1137358.
This was in event.c:process_socket. The variable pt
was previously used lower in the function, but after the patch
above was applied it is now only used in a local if scope.
This is basically a code clean up patch.
Thanks,
Chris
--
Chris Wilson
http://vigilantsw.com/
Vigilant Software, LLC
Index: server/mpm/event/event.c
===================================================================
--- server/mpm/event/event.c (revision 1137629)
+++ server/mpm/event/event.c (working copy)
@@ -787,7 +787,6 @@
int my_thread_num)
{
conn_rec *c;
- listener_poll_type *pt;
long conn_id = ID_FROM_CHILD_THREAD(my_child_num, my_thread_num);
int rc;
ap_sb_handle_t *sbh;
@@ -795,6 +794,7 @@
ap_create_sb_handle(&sbh, p, my_child_num, my_thread_num);
if (cs == NULL) { /* This is a new connection */
+ listener_poll_type *pt;
cs = apr_pcalloc(p, sizeof(conn_state_t));
@@ -845,7 +845,6 @@
else {
c = cs->c;
c->sbh = sbh;
- pt = cs->pfd.client_data;
c->current_thread = thd;
}
