On 31.01.2012 22:30, Stefan Fritsch wrote:
On Tuesday 31 January 2012, Gregg Smith wrote:
On 1/29/2012 11:53 AM, Stefan Fritsch wrote:
On Wednesday 25 January 2012, Jim Jagielski wrote:
Looking over the code, impl as a hook seems more "isolated",
rather than the current impl which is intrusive (which is
part of what we're trying to avoid, aren't we?)

OK, patch is attached. This needs review/testing for Windows.

Patched trunk at r1237447, saw same after patching 2.4-HEAD so I
tried trunk.

Regards,
Gregg

Compiling...
service.c
.\server\mpm\winnt\service.c(38) : error C2370: 'mpm_winnt_module'
: redefinition; different storage class

c:\build3\httpd-head_r1237447\server\mpm\winnt\mpm_winnt.h(70)

: see declaration of 'mpm_winnt_module'

Oops. Please try this in addition. Thanks for the testing.

No info about Windows, but: I applied the patches on trunk and ran the test suite against a reallyall build on Solaris 10. No test failures.

Regards,

Rainer

Reply via email to