Hi Joe, Two questions about this change:
- In modssl_register_npn, it appears that the code creates new npn_advertfns and npn_negofns arrays on every call, even if they already exist. This would seem to prevent multiple modules from registering callbacks. Presumably this is not intended? Am I misreading the code? - The old optional hooks were both declared as RUN_ALL, but the new implementation seems to stop calling callbacks as soon as one returns OK, which is different behavior than before. Is there a reason for this change? Best, -Matthew On Wed, May 29, 2013 at 10:36 AM, Joe Orton <[email protected]> wrote: > Guenter, can you test if the attached compiles on Windows? It is > nothing special so it should be OK. > > This redesigns the NPN API with a cheap and crappy callback interface > which doesn't rely on the actual hooks API; it is not pretty but it > avoids the inter-module hard linkage issue (which is even more crap and > I should have noticed when committing, sorry about that). > > (Tested to compile and not segfault on Unix but no further, I'll mock up > something to test properly.) > > Regards, Joe >
