On Mon, Nov 25, 2013 at 4:24 PM, Yann Ylavic <[email protected]> wrote:
>
> Index: server/mpm/event/fdqueue.c
> ===================================================================
> --- server/mpm/event/fdqueue.c (revision 1545301)
> +++ server/mpm/event/fdqueue.c (working copy)
> @@ -17,7 +17,7 @@
> #include "fdqueue.h"
> #include "apr_atomic.h"
>
> -static zero_pt = (APR_INT32_MAX-1)>>2;
> +static const apr_uint32_t zero_pt = ((apr_uint32_t)1 << 31);
>
> struct recycled_pool
> {
> @@ -27,10 +27,12 @@ struct recycled_pool
>
> struct fd_queue_info_t
> {
> - apr_int32_t idlers; /**
> - * 0 or positive: number of idle worker
> threads
> - * negative: number of threads blocked
> waiting
> - * for an idle worker
> + apr_uint32_t idlers; /**
> + * >= zero_pt: (zero_pt - idlers) is the
> number
> + * of idle worker threads
> + * < zero_pt: (idlers - zero_pt) is the
> number
> + * of threads blocked waiting for
> + * an idle worker
> */
>
Oups, the comment should be :
+ apr_uint32_t idlers; /**
+ * >= zero_pt: (idlers - zero_pt) is the
number
+ * of idle worker threads
+ * < zero_pt: (zero_pt - idlers) is the
number
+ * of threads blocked waiting for
+ * an idle worker
*/
