I'd love to see these things fixed, because they add up. If you post them here
they are likely to be reviewed very quickly, as they'll no doubt be simple to
review.
Cool. Here's a patch for the case I just mentioned. It also eliminates an
un-needed automatic (yes, I obsess about stack frames too). diff against trunk.
Kean
Index: modules/proxy/mod_proxy_fcgi.c
===================================================================
--- modules/proxy/mod_proxy_fcgi.c (revision 1550327)
+++ modules/proxy/mod_proxy_fcgi.c (working copy)
@@ -757,14 +757,11 @@
char server_portstr[32];
conn_rec *origin = NULL;
proxy_conn_rec *backend;
+ apr_uri_t *uri;
proxy_dir_conf *dconf = ap_get_module_config(r->per_dir_config,
&proxy_module);
- apr_pool_t *p = r->pool;
-
- apr_uri_t *uri = apr_palloc(r->pool, sizeof(*uri));
-
ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(01076)
"url: %s proxyname: %s proxyport: %d",
url, proxyname, proxyport);
@@ -790,7 +787,8 @@
backend->is_ssl = 0;
/* Step One: Determine Who To Connect To */
- status = ap_proxy_determine_connection(p, r, conf, worker, backend,
+ uri = apr_palloc(r->pool, sizeof(*uri));
+ status = ap_proxy_determine_connection(r->pool, r, conf, worker, backend,
uri, &url, proxyname, proxyport,
server_portstr,
sizeof(server_portstr));
@@ -814,7 +812,7 @@
}
/* Step Three: Process the Request */
- status = fcgi_do_request(p, r, backend, origin, dconf, uri, url,
+ status = fcgi_do_request(r->pool, r, backend, origin, dconf, uri, url,
server_portstr);
cleanup:
