On Thu, Dec 12, 2013 at 1:54 AM, Kean Johnston <kean.johns...@gmail.com>wrote:
> I'd love to see these things fixed, because they add up. If you post them >> here they are likely to be reviewed very quickly, as they'll no doubt be >> simple to review. >> > Cool. Here's a patch for the case I just mentioned. It also eliminates an > un-needed automatic (yes, I obsess about stack frames too). diff against > trunk. > Note that in this particular cases (ie. "uri = apr_palloc(p, sizeof(*uri))" used in proxy_(ajp|fcgi|http|scgi|wstunnel)_handler), the "local" uri would better be declared on the stack (ie. apr_uri_t uri; and &uri used accordingly), so to avoid the allocation completely. Regards, Yann.
