Hi,

commit 1553824 (1573360 in 2.4.x) breaks the compatibility in arguments passed to "exec:/path/to/program" pass phrase program. This should be clear from the following part of mentioned commit(s):

-        argv[1] = cpVHostID;
-        argv[2] = cpAlgoType;
-        argv[3] = NULL;
+        argv[1] = ppcb_arg->key_id;
+        argv[2] = NULL;

Was this change intentional in trunk? If yes, I will document this, because the change of mod_ssl documentation was not part of this patch.

However, I think this should not be accepted in 2.4.x branch, because it breaks compatibility with external pass phrase programs in the stable branch without any reason.

I will write a patch (will attach later) reintroducing ssl_util_algotypeof and ssl_util_algotypestr and passing the same arguments as it used to before this commit.

Is anyone against this proposed fix for 2.4.x?

Regards,
Jan Kaluza

Reply via email to