On 16.04.2014 09:45, Jan Kaluža wrote: > On 04/16/2014 09:35 AM, Plüm, Rüdiger, Vodafone Group wrote: >> Are we sure that ppcb_arg->key_id always contains a ':'? > > I've checked that part of patch and if I'm right, the key_id is only > created by asn1_table_vhost_key(...) like this: > > char *key = apr_psprintf(p, "%s:%d", id, i);
Yes, exactly. It is then assigned to ppcb_arg.key_id in ssl_load_encrypted_pkey(), which is the only place which configures ssl_pphrase_Handle_CB as a callback. There's another backwards-compatibility fix I consider necessary for 2.4.x (see https://issues.apache.org/bugzilla/show_bug.cgi?id=56306#c8), so I think I'll wait a few days for feedback on that one before combining them into a single proposal for 2.4.x (trunk shouldn't need them). Kaspar
