Hi,

I was about to submit a patch in order to remove the 'register' keyword in a variable declaration in 'modules/http/http_protocol.c'.
See 'ap_method_list_remove()'

I also wanted to simplify code in the surrounding ap_method_* functions.


However, I think that:
    - in 'ap_method_list_add()',
          l->method_mask |= (AP_METHOD_BIT << methnum);
      should be in the
          if (methnum != M_INVALID) { ... }
     block

    - in 'ap_method_list_remove()',
          l->method_mask |= ~(AP_METHOD_BIT << methnum);
      should be in the
          if (methnum != M_INVALID) { ... }
     block


Do you agree ?

Best regards,
CJ

Reply via email to