On Sat, Jul 19, 2014 at 2:04 PM, Christophe JAILLET < [email protected]> wrote:
> Hi, > > I was wondering if logged message, at least APLOG_ERR or APLOG_EMERG and > APLOG_CRIT, should all have a corresponding APLOGNO()? > > Using the following regex: > ap_log_.?error.*(_ERR|_EMERG|_CRIT)[^A]*$ > many places with "missing" APLOGNO can be found. > > There are some false positives because the [^A]* at the end of the regex > is here to check, in a more or less good way, the absence of APLOGNO. > Most common mistakes are when APLOGNO is on the following line. > > > If you think that adding the APLOGNO would be improvement, would you like > me to: > 1) propose patches that put back APLOGNO on the same line as > ap_log_.?error, which seems to be the most common > > 2) add APLOGNO missing for APLOG_ERR, APLOG_EMERG and APLOG_CRIT? > IMO anything more important than DEBUG needs a number, but I think even many DEBUG messages have numbers. > > 3) only add these APLOGNO for new modules (mod_ssl_ct and associated > files need many) > Ouch, I will fix my mess; thanks for pointing this out! > > > Best regards, > CJ > > -- Born in Roswell... married an alien... http://emptyhammock.com/ http://edjective.org/
