On Wed, Aug 19, 2015 at 9:13 AM, <[email protected]> wrote: > Author: icing > Date: Wed Aug 19 14:13:49 2015 > New Revision: 1696592 > > URL: http://svn.apache.org/r1696592 > Log: > mod_h2 compiles warning free in maintainer-mode > > --- httpd/httpd/trunk/modules/http2/h2_alt_svc.c (original) > +++ httpd/httpd/trunk/modules/http2/h2_alt_svc.c Wed Aug 19 14:13:49 2015 > @@ -42,13 +42,13 @@ void h2_alt_svc_register_hooks(void) > * - do not use quotation marks > */ > h2_alt_svc *h2_alt_svc_parse(const char *s, apr_pool_t *pool) { > - const char *sep = strchr(s, '='); > + const char *sep = strchr((char *)s, '='); >
We solve these issues with ap_strchr_c, ap_strrchr_c, ap_strstr_c etc. This avoids the casts, which are always worth avoiding for other analysis tools and inadvertent overwriting.
