> Am 01.11.2015 um 08:22 schrieb Christophe JAILLET > <[email protected]>: > > Hi, > > Le 30/10/2015 17:15, [email protected] a écrit : >> [...]+ if (status == APR_SUCCESS && padlen) { >> + if (padlen) { >> + char pad[256]; >> + memset(pad, 0, padlen); > > You could save this 'pad' buffer and the 'memset' by also using the data from > the 'static char immortal_zeros[256];' introduced above.
Good idea, will do. > Maybe, using NGHTTP2_MAX_PADLEN instead of the 256 hard coded value would be > cleaner? That is in an internal header file from nghttp2. Will add an own #define in mod_http2 headers to make it clear where the limit comes from. //Stefan
