I can check that change on the test setup and meditate about the docs phrasing a bit...
> Am 19.11.2015 um 14:11 schrieb Yann Ylavic <ylavic....@gmail.com>: > > On Thu, Nov 19, 2015 at 2:04 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >>> >>> Hmm, then r1709587 swithed it back to "H2Direct on for http:, off for >>> https: requests", whereas the commit states "H2Direct off, on when h2c >>> is in Protocols". >>> What's the status exactly? >> >> The status in trunk is as documented in trunk ;-) >> >> H2Direct, unless set otherwise, is enabled if and only if a server has >> "Protocols h2c". > > Is that what "H2Direct on for http:, off for https: requests" means? oO > (I prefer the commit message terms in this case :p ) > >> >> The reason for enabling it also for "h2" hosts in the test framework is to >> enable >> tests to run on machines that do not have SSL+ALPN in the perl tests. This >> is true >> for OS X, unfortunately. > > The tests framework enables it unconditionally provided mod_http2 is loaded. > > Was thinking of something like: > > Index: t/conf/http2.conf.in > =================================================================== > --- t/conf/http2.conf.in (revision 1715025) > +++ t/conf/http2.conf.in (working copy) > @@ -6,10 +6,11 @@ > <IfModule http2_module> > > LogLevel http2:debug > - H2Direct on > > <VirtualHost h2c> > Protocols h2c http/1.1 > + # Should be implicit with h2c > + #H2Direct on > > <IfModule @CGI_MODULE@> > <Directory @SERVERROOT@/htdocs/modules/h2> > @@ -32,6 +33,7 @@ > > <VirtualHost localhost:h2> > Protocols h2 http/1.1 > + H2Direct on > > SSLEngine on > SSLCACertificateFile @SSLCA@/asf/certs/ca.crt > @@ -74,6 +76,7 @@ > > <VirtualHost test.example.org:h2> > Protocols h2 http/1.1 > + H2Direct on > > SSLEngine on > SSLCACertificateFile @SSLCA@/asf/certs/ca.crt > @@ -91,6 +94,7 @@ > > <VirtualHost test2.example.org:h2> > Protocols http/1.1 h2 > + H2Direct on > </VirtualHost> > > <VirtualHost test-ser.example.org:h2> > -- > >> >> The doc in 2.4.x is not updated as the http2 modules is not updated, as I am >> waiting >> for the proposed core-protocols changes to be backported. > > Working on it ;) > > > Thanks, > Yann.
