Le 04/10/2015 12:10, [email protected] a écrit :
Author: minfrin
Date: Sun Oct  4 10:10:51 2015
New Revision: 1706669

URL: http://svn.apache.org/viewvc?rev=1706669&view=rev
Log:
core: Extend support for asynchronous write completion from the
network filter to any connection or request filter.
[...]
Modified: httpd/httpd/trunk/server/util_filter.c
URL: 
http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_filter.c?rev=1706669&r1=1706668&r2=1706669&view=diff
==============================================================================
--- httpd/httpd/trunk/server/util_filter.c (original)
+++ httpd/httpd/trunk/server/util_filter.c Sun Oct  4 10:10:51 2015
[...]
+AP_DECLARE(apr_status_t) ap_filter_reinstate_brigade(ap_filter_t *f,
+                                                     apr_bucket_brigade *bb,
+                                                     apr_bucket **flush_upto)
+{
[...]
+
+    *flush_upto = NULL;
+
[...]
+                ap_log_cerror(APLOG_MARK, APLOG_TRACE8, 0, f->c,
+                              "seen in brigade%s: bytes: %" APR_SIZE_T_FMT
+                              ", non-file bytes: %" APR_SIZE_T_FMT ", eor "
+                              "buckets: %d, morphing buckets: %d",
+                              flush_upto == NULL ? " so far"                      
   <----------------------
+                                                 : " since last flush point",
+                              bytes_in_brigade,
+                              non_file_bytes_in_brigade,
+                              eor_buckets_in_brigade,
+                              morphing_bucket_in_brigade);
+            }
+            /*
+             * Defer the actual blocking write to avoid doing many writes.
+             */
+            *flush_upto = next;

Shouldn't the 'flush_upto' indicated here be a '*flush_upto'?
Obviously there is no impact, just TRACE8 message accuracy.

(spotted by smatch)

CJ

Reply via email to