On Fri, Aug 19, 2016 at 6:14 PM, Yann Ylavic <[email protected]> wrote:
>
> How couldn't it figure out that apr_pstrcat() never returns NULL?
> Clever compilers should really read all the docs :)
>
:)
> Anyway, "fixed" in r1756976, thanks!
>
Thank you!
My survey of --enable-modules=reallyall at the moment...
after fixing one of my own noisy bits...
httpd-2.x/modules/filters/mod_crypto.c: In function
'parse_pass_conf_binary':
httpd-2.x/modules/filters/mod_crypto.c:127:9: warning: ISO C90 forbids
mixed declarations and code [-Wdeclaration-after-statement]
const char *name = ap_server_root_relative(cmd->temp_pool, arg);
^
I expect this is on minfrin. That seems to be the remaining extent
of all errors we caused on trunk builds, modulo ldap stuff which won't
build against apr-2.0 and some other feature-specific stuff that
doesn't align with the FC22 instance I'm testing on.
And on FC22, with the new ar syntax, I have to deal with thousands
of these stupid emits daily...
ar: `u' modifier ignored since `D' is the default (see `U')
It would be nice if any RedHat/gnu toolchain wonk who adopted this
change would speak up about the proper fix to our configure.in.
We also have breakage in the bundled FC22 bison sources, some
clown thinks C++ comments in C sources are cute, but this appears
to have nothing to do with httpd's build schema...
util_expr_scan.c: In function 'ap_expr_yyensure_buffer_stack':
util_expr_scan.c:2205:21: error: C++ style comments are not allowed in ISO
C90
num_to_alloc = 1; // After all that talk, this was set to 1 anyways...
^
util_expr_scan.c:2205:21: error: (this will be reported only once per input
file)
build/httpd2x-apr20-ossl110/build/rules.mk:207: recipe for target
'util_expr_scan.lo' failed
That's classy.
This is looking pretty good, update tomorrow on oddball t/TEST issues.