On Fri, Aug 19, 2016 at 8:17 PM, William A Rowe Jr <[email protected]> wrote:
> On Fri, Aug 19, 2016 at 6:14 PM, Yann Ylavic <[email protected]> wrote: > >> >> How couldn't it figure out that apr_pstrcat() never returns NULL? >> Clever compilers should really read all the docs :) >> > > :) > > >> Anyway, "fixed" in r1756976, thanks! >> > > Thank you! > > My survey of --enable-modules=reallyall at the moment... > after fixing one of my own noisy bits... > > httpd-2.x/modules/filters/mod_crypto.c: In function > 'parse_pass_conf_binary': > httpd-2.x/modules/filters/mod_crypto.c:127:9: warning: ISO C90 forbids > mixed declarations and code [-Wdeclaration-after-statement] > const char *name = ap_server_root_relative(cmd->temp_pool, arg); > ^ > > I expect this is on minfrin. That seems to be the remaining extent > of all errors we caused on trunk builds, modulo ldap stuff which won't > build against apr-2.0 and some other feature-specific stuff that > doesn't align with the FC22 instance I'm testing on. > > And on FC22, with the new ar syntax, I have to deal with thousands > of these stupid emits daily... > > ar: `u' modifier ignored since `D' is the default (see `U') > > It would be nice if any RedHat/gnu toolchain wonk who adopted this > change would speak up about the proper fix to our configure.in. > > We also have breakage in the bundled FC22 bison sources, some > clown thinks C++ comments in C sources are cute, but this appears > to have nothing to do with httpd's build schema... > > util_expr_scan.c: In function 'ap_expr_yyensure_buffer_stack': > util_expr_scan.c:2205:21: error: C++ style comments are not allowed in ISO > C90 > num_to_alloc = 1; // After all that talk, this was set to 1 anyways... > ^ > util_expr_scan.c:2205:21: error: (this will be reported only once per > input file) > build/httpd2x-apr20-ossl110/build/rules.mk:207: recipe for target > 'util_expr_scan.lo' failed > > That's classy. > > This is looking pretty good, update tomorrow on oddball t/TEST issues. > And as promised, 2.x + apr-2.0.0-dev with -enable-mods-shared=reallyall against t/TEST, we immediately bust on mod_ssl_ct.so [Sat Aug 20 17:16:18.856144 2016] [ssl_ct:error] [pid 24988:tid 140055724791936] AH02717: Directive CTSCTStorage is required AH00014: Configuration check failed Is anyone maintaining that bit? There's a fundamental problem any time we can fail to start the server by simply loading a module. Some sensible default must be present. This needs to be fixed simply to have our tests available in this schema. Commenting out mod_ssl_ct.so... [Sat Aug 20 18:44:00.537713 2016] [core:warn] [pid 27411:tid 140510888274048] AH00111: Config variable ${DOCROOT} is not defined pops up on every test. Something we've changed in httpd that wasn't reflected in the test suite, I'm guessing? t/apache/passbrigade.t (Wstat: 0 Tests: 114 Failed: 1) Failed test: 56 t/ssl/varlookup.t (Wstat: 0 Tests: 81 Failed: 2) Failed tests: 56, 58 passbrigade.t #56 is worrying. It doesn't fail consistently. I've attached a diff of a good vs. bad error/access/ssl_access logs and t/TEST output varlookup.t isn't really a worrying, seems to be some confusion on my host name which couldn't be righted with -servername etc. Very clearly an openssl cert generation issue, not a defect in httpd/mod_ssl. # testing : SSL_SERVER_SAN_DNS_0 # expected: 'localhost' # received: 'hub' not ok 56 # testing : SSL_SERVER_SAN_OTHER_dnsSRV_0 # expected: '_https.localhost' # received: '_https.hub' not ok 58 Long story short, httpd 2.5.0-dev is looking awfully solid, as is the test framework.
diff -ru passbrigade-good/error_log passbrigade-fail/error_log --- passbrigade-good/error_log 2016-08-20 13:36:15.752148452 -0500 +++ passbrigade-fail/error_log 2016-08-20 13:36:24.727339685 -0500 @@ -315,10 +315,10 @@ [timestamp] [proxy_hcheck:debug] [pid:tid] mod_proxy_hcheck.c(992): AH03265: watchdog callback registered (_proxy_hcheck_) [timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(459): AH02974: Watchdog: found parent providers. [timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(505): AH02977: Watchdog: found child providers. +[timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(513): AH02978: Watchdog: Looking for child (_default_). [timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(513): AH02978: Watchdog: Looking for child (_proxy_hcheck_). [timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(538): AH02979: Watchdog: Created child worker thread (_proxy_hcheck_). [timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(513): AH02978: Watchdog: Looking for child (_singleton_). -[timestamp] [watchdog:debug] [pid:tid] mod_watchdog.c(513): AH02978: Watchdog: Looking for child (_default_). [timestamp] [session_crypto:info] [pid:tid] AH01849: The crypto library 'openssl' was loaded successfully [timestamp] [example_hooks:notice] [pid:tid] AH03297: x_pre_mpm() [timestamp] [mpm_worker:notice] [pid:tid] AH00292: Apache/2.5.0-dev (Unix) OpenSSL/1.1.0-pre7-dev configured -- resuming normal operations @@ -403,6 +403,7 @@ [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1833): AH00924: worker http://hub:8529/ shared already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1875): AH00926: worker http://hub:8529/ local already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1833): AH00924: worker http://hub:8529/ shared already initialized +[timestamp] [proxy_hcheck:debug] [pid:tid] mod_proxy_hcheck.c(869): AH03313: apr_thread_pool_create() with 16 threads succeeded [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1875): AH00926: worker http://hub:8529/ local already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1833): AH00924: worker http://hub:8529/ shared already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1875): AH00926: worker http://hub:8529/ local already initialized @@ -443,7 +444,6 @@ [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1875): AH00926: worker http://hub:8529/ local already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1833): AH00924: worker http://hub:8529/ shared already initialized [timestamp] [proxy:debug] [pid:tid] proxy_util.c(1875): AH00926: worker http://hub:8529/ local already initialized -[timestamp] [proxy_hcheck:debug] [pid:tid] mod_proxy_hcheck.c(869): AH03313: apr_thread_pool_create() with 16 threads succeeded [timestamp] [example_hooks:notice] [pid:tid] AH03297: x_create_connection() [timestamp] [example_hooks:notice] [pid:tid] AH03297: x_create_request() [timestamp] [authz_core:debug] [pid:tid] mod_authz_core.c(834): [client ip:port] AH01628: authorization result: granted (no directives) @@ -3078,6 +3078,8 @@ [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes +[mod_test_pass_brigade] wrote 1024 of 10[timestamp] [mpm_worker:error] [pid:tid] AH00287: server is within MinSpareThreads of MaxRequestWorkers, consider raising the MaxRequestWorkers setting +24 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes @@ -3413,8 +3415,6 @@ [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes -[mod_test[timestamp] [mpm_worker:error] [pid:tid] AH00287: server is within MinSpareThreads of MaxRequestWorkers, consider raising the MaxRequestWorkers setting -_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes [mod_test_pass_brigade] wrote 1024 of 1024 bytes diff -ru passbrigade-good/test.log passbrigade-fail/test.log --- passbrigade-good/test.log 2016-08-20 13:33:41.480861844 -0500 +++ passbrigade-fail/test.log 2016-08-20 13:33:51.466074547 -0500 @@ -2512,17 +2512,19 @@ #Server: Apache/2.5.0-dev (Unix) OpenSSL/1.1.0-pre7-dev #Vary: In-If1 #Content-Length: 0 +#Client-Aborted: die #Client-Date: [timestamp] #Client-Peer: 127.0.0.1:8529 #Client-Response-Num: 1 #Client-Transfer-Encoding: chunked #DMMATCH1: 1 #X-Content-Length-Note: added by Apache::TestRequest +#X-Died: EOF when chunk header expected at /usr/share/perl5/vendor_perl/Net/HTTP/Methods.pm line 525. # # testing : bytes in body -# expected: 6144000 +# expected: 6086656 # received: 6144000 -ok 113 +not ok 113 #lwp request: #GET http://hub:8529/test_pass_brigade?8192,10240000 HTTP/1.1 #User-Agent: libwww-perl/6.15 @@ -2545,8 +2547,13 @@ # expected: 10240000 # received: 10240000 ok 114 -ok -All tests successful. -Files=1, Tests=114, 3 wallclock secs ( 0.12 usr 0.01 sys + 2.18 cusr 0.34 csys = 2.65 CPU) -Result: PASS +Failed 1/114 subtests + +Test Summary Report +------------------- +t/apache/passbrigade.t (Wstat: 0 Tests: 114 Failed: 1) + Failed test: 113 +Files=1, Tests=114, 3 wallclock secs ( 0.12 usr 0.01 sys + 2.20 cusr 0.34 csys = 2.67 CPU) +Result: FAIL +Failed 1/1 test programs. 1/114 subtests failed. done
