On Fri, Dec 30, 2016 at 6:02 PM, Yann Ylavic <ylavic....@gmail.com> wrote: > > Any reason why we need to force the "most" selection for proxy modules? > This is already the default module_selection, and if --enable-modules > is used (with the admin supposed to know what [s]he does), it'll > break... > > Also it seems that we force module_default to the value of > --enable-proxy (when "shared" or "static"), though I see no reason to > force "static". > Forcing "shared" is probably relevant if we don't want proxy > submodules to be loaded statically with mod_proxy itself being > dynamic, but one may want a static mod_proxy with dynamic mod_proxy_* > (at least it doesn't break).
I'm thinking of the attached patch...
Index: modules/proxy/config.m4 =================================================================== --- modules/proxy/config.m4 (revision 1776295) +++ modules/proxy/config.m4 (working copy) @@ -5,18 +5,14 @@ APACHE_MODPATH_INIT(proxy) proxy_objs="mod_proxy.lo proxy_util.lo" APACHE_MODULE(proxy, Apache proxy module, $proxy_objs, , most) -dnl set aside module selections and default, and set the module default to the -dnl same scope (shared|static) as selected for mod proxy, along with setting -dnl the default selection to "most" for remaining proxy modules, mirroring the -dnl behavior of 2.4.1 and later, but failing ./configure only if an explicitly -dnl enabled module is missing its prereqs -save_module_selection=$module_selection +dnl set aside module default, and set it to the same scope shared if selected +dnl for mod proxy, along with setting the default selection to "most" for +dnl remaining proxy modules, mirroring the behavior of 2.4.1 and later, but +dnl failing ./configure only if an explicitly enabled module is missing its +dnl prereqs save_module_default=$module_default -if test "x$enable_proxy" != "xno"; then - module_selection=most - if test "$enable_proxy" = "shared" -o "$enable_proxy" = "static"; then - module_default=$enable_proxy - fi +if test "x$enable_proxy" = "xshared"; then + module_default=shared fi proxy_connect_objs="mod_proxy_connect.lo" @@ -78,7 +74,6 @@ APACHE_MODULE(proxy_hcheck, [reverse-proxy health- APR_ADDTO(INCLUDES, [-I\$(top_srcdir)/$modpath_current]) -module_selection=$save_module_selection module_default=$save_module_default APACHE_MODPATH_FINISH
