Yes, that was mixing the order. The attached v4 compiles and runs the h2 tests for me without errors.
ptrans_and_slaves_allocator-v4.patch
Description: Binary data
> Am 06.02.2017 um 14:43 schrieb Yann Ylavic <ylavic....@gmail.com>: > > On Mon, Feb 6, 2017 at 2:31 PM, Stefan Eissing > <stefan.eiss...@greenbytes.de> wrote: >> Currently running some tests. Have crashes on the original patch in my test >> suite. Fixed one, hunting for the next... > > I think it comes from my change that creates slave connections from > master->pool (instead of mplx's), because now slave's pool is already > destroyed when h2_mplx_release_and_join()->task_destroy()->h2_slave_destroy() > is called (hence the crash). > > I restored your original code in this new (attached) patch. > > @s.priebe, would you test this one please? > <ptrans_and_slaves_allocator-v3.patch> Stefan Eissing <green/>bytes GmbH Hafenstrasse 16 48155 Münster www.greenbytes.de
