On 02/16/2017 02:49 AM, Yann Ylavic wrote:
+#define FILE_BUCKET_BUFF_SIZE (64 * 1024 - 64) /* > APR_BUCKET_BUFF_SIZE */
So, I had already hacked my O_DIRECT bucket case to just be a copy of APR's file bucket, minus the mmap() logic. I tried making this change on top of it...
...and holy crap, for regular HTTP it's *faster* than our current mmap() implementation. HTTPS is still slower than with mmap, but faster than it was without the change. (And the HTTPS performance has been really variable.)
Can you confirm that you see a major performance improvement with the with the new 64K file buffer? I'm pretty skeptical of my own results at this point... but if you see it too, I think we need to make *all* these hard-coded numbers tunable in the config.
--Jacob
