The patches look great! Will test on next occasion! Thanks! :)

> Am 22.09.2017 um 14:02 schrieb Yann Ylavic <ylavic....@gmail.com>:
> 
> On Thu, Sep 21, 2017 at 2:54 PM, Yann Ylavic <ylavic....@gmail.com> wrote:
>> On Thu, Sep 21, 2017 at 2:51 PM, Eric Covener <cove...@gmail.com> wrote:
>>> On Thu, Sep 21, 2017 at 8:44 AM, Yann Ylavic <ylavic....@gmail.com> wrote:
>>>> On Thu, Sep 21, 2017 at 2:11 PM, Eric Covener <cove...@gmail.com> wrote:
>>>>> 
>>>>> IIUC it should be safe to extend module_struct with a minor bump to
>>>>> add 'int flags' to the bottom, but when you check the value you'd need
>>>>> to check the MMN first. In the module you'd then just have some flags
>>>>> or'ed together after register_hooks.
>>>> 
>>>> Something like the attached patch might do it (untested, no MMN minor 
>>>> bump).
>>>> 
>>>>> 
>>>>> (hopefully someone will check my work)
>>>> 
>>>> Since modules (module_struct) are déclared globally, unspecified
>>>> fields at the end of the struct should be initialized to zero, so it
>>>> should be safe.
>>> 
>>> I was thinking about modules compiled against the previous definition
>>> / out of tree.
>> 
>> Right, it's missing some #ifdefs MMN too :)
> 
> r1809302 and r1809303, does it work for you Stefan?
> 
> We have to change the AP_MODULE_HAS_FLAGS macro with the appropriate
> MMN if we'd backport...

Reply via email to