On Sat, Feb 17, 2018 at 02:06:20PM -0000, minf...@apache.org wrote:
> Author: minfrin
> Date: Sat Feb 17 14:06:20 2018
> New Revision: 1824592
> URL: http://svn.apache.org/viewvc?rev=1824592&view=rev
> Update proposal with fix for rpluem/jorton.
Extending dav_resource still breaks binary backards compat with all(?)
consumers of this API, or am I missing something here?
Look at what mod_dav_svn does with the struct for an example:
If breaking backwards compat for module API is fine for 2.4 (and I'm
still generally on the fence about this), I think it should at least be
a "hard" break, e.g. by s/dav_register_provider/dav_register_provider2/.
That way incompatible module combinations break at LoadModule time
rather than with segfaults.
> Modified: httpd/httpd/branches/2.4.x/STATUS
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Sat Feb 17 14:06:20 2018
> @@ -180,6 +180,13 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
> minfrin: 2.4.x patch not applying for me, trunk patches work
> icing: fixed the patch to include complete new files instead of svn's
> internal optimizations
> + *) mod_dav: Allow other modules to become providers and add ACLs
> + to the DAV response. Requires a release of apr-util v1.6.
> + trunk patch: http://svn.apache.org/r1748322
> + http://svn.apache.org/r1824590
> + 2.4.x: trunk works modulo CHANGES/MMN
> + +1: minfrin
> PATCHES/ISSUES THAT ARE BEING WORKED
> [ New entries should be added at the START of the list ]
> @@ -255,23 +262,6 @@ PATCHES/ISSUES THAT ARE BEING WORKED
> make it nonblocking (by default)?
> jim: Non-blocking seems the best way to handle...
> - * mod_dav: Allow other modules to become providers and add ACLs
> - to the DAV response. Requires a release of apr-util v1.6.
> - trunk patch: http://svn.apache.org/r1748322
> - 2.4.x: trunk works modulo CHANGES/MMN
> - +1: minfrin
> - rpluem asks: Will this compile with apr-util < v1.6 and keep
> - mod_dav working (without the new features of the patch of course)?
> - I doubt that we will require apr-util 1.6 for the lifetime of 2.4.x
> - (see the discussion around ap_cstr_casecmp[n] an apr 1.6)
> - minfrin: Yes, as you can see in the patch everything applies only
> - if APR_XML_X2T_PARSED is defined, and the patch was tested with
> - both apr-util v1.6 and apr-util v1.5.
> - -1: jorton, breaks binary backwards compat per dev@ discuss
> - msgid <20160902120654.ga12...@redhat.com>
> - (& also, making the structure change with apr-util version
> - means it breaks binary compat across an apr-util upgrade?)
> * Support PCRE2 (10.x) in place of PCRE (8.x).
> Submitted by: wrowe, Petr Pisar [ppisar redhat.com]
> trunk patches: