It is not a logging only change, it solves crashes in libapr1.dll
(was not safe to use r / r->pool in the event of a timeout )
I plan to ship AL build 2.4.32 with this fix.
On Monday 12/03/2018 at 14:42, Rainer Jung wrote:
Hi Steffen, hi list,
Am 12.03.2018 um 14:07 schrieb Steffen:
I think it should released with 2.4.32 (+) .
Endly solved a pain with all that crashes.
thanks for reminding us of that problem.
Since it is a logging only change for INFO log level and our default
log level is WARN, plus as far as I understand you it is not a
regression, I would personally tend to not rate this as a showstopper.
Regards,
Rainer
On Monday 12/03/2018 at 13:33, Yann Ylavic wrote:
On Mon, Mar 12, 2018 at 1:03 PM, Yann Ylavic <ylavic....@gmail.com>
wrote:
The fix could be something like this:
Index: modules/http/http_request.c
===================================================================
--- modules/http/http_request.c (revision 1826315)
+++ modules/http/http_request.c (working copy)
@@ -484,9 +484,8 @@ AP_DECLARE(void) ap_process_request(request_rec *r
* It is still safe to use r / r->pool here as the eor
bucket
* could not have been destroyed in the event of a
timeout.
*/
- ap_log_rerror(APLOG_MARK, APLOG_INFO, rv, r, APLOGNO(01581)
- "Timeout while writing data for URI %s to the"
- " client", r->unparsed_uri);
+ ap_log_cerror(APLOG_MARK, APLOG_INFO, rv, c, APLOGNO(01581)
+ "flushing data to the client");
}
}
if (ap_extended_status) {
_
r1826543
