Hi, Steffen; Good catch. That particular change didn't have a CHANGES entry, so it explains why it's missing. Luckily, there are no user-visible changes (other than the error message being correct), so I think we're good to move forward. Would love to see a test case added around this if you're so inclined :-)
Thanks! -- Daniel Ruggeri On 9/21/2018 5:59 AM, Steffen wrote: > Maybe I overlook it: > > I miss in the change log: > > http://svn.apache.org/viewvc?view=revision&sortby=date&revision=1840546 > > Looks it needs special windows test attention. > > Description: > > Merge r1801144, r1801148, r1801456 from trunk: > > mpm_winnt: Factor out a helper function to parse the type of an accept > filter and use an appropriate enum for it. > > This makes the code in winnt_accept() a bit easier to follow. As a minor > side effect, it also fixes a small bug where the "unrecognized > AcceptFilter > '%s'" log entry would always contain "none" instead of the actually > unrecognized kind of the accept filter. > > mpm_winnt: Fix typo in the logged message in winnt_get_connection(). > > mpm_winnt: Following up on r1801144, use the new accept_filter_e enum > values in a couple of missed places in winnt_accept(). > > Submitted by: kotkov > Reviewed by: jailletc36, jim (via inspection), wrowe > > > > On 18-09-18 02:56, Daniel Ruggeri wrote: >> Hi, all; >> Please find below the proposed release tarball and signatures: >> https://dist.apache.org/repos/dist/dev/httpd/ >> >> I would like to call a VOTE over the next few days to release this >> candidate tarball as 2.4.35: >> [ ] +1: It's not just good, it's good enough! >> [ ] +0: Let's have a talk. >> [ ] -1: There's trouble in paradise. Here's what's wrong. >> >> The computed digests of the tarball up for vote are: >> md5: 92ddccfbd43b533578499d1faaad17fe *httpd-2.4.35.tar.gz >> sha1: b7996c2c1f7ff5bb217114fe5354a19a5207ab62 *httpd-2.4.35.tar.gz >> sha256: 31c2c82c9cd34749cbb60d04619d9aa3fb0814ab22246ad588d2426dde90c72c >> *httpd-2.4.35.tar.gz >> >
