On Fri, Oct 12, 2018 at 4:54 PM William A Rowe Jr <[email protected]> wrote:
> Great, I'll proceed with changing ab.c to remove the hack, since it is > unneeded when ab.c is compiled by the same toolchain as libcrypto.dll, > isn't available in non-openssl distributions, and was deprecated in 1.1.1 > again. > Note, I'll only proceed to remove the hack from trunk. I see no reason to make any cosmetic or build changes to 2.4.x branch. Any fallout to the trunk change will be uncovered in alpha/beta review. If we are unwilling to support the feature in httpd.exe we should not do so for ab.c either. (IIRC there was some subtle lingering BIO usage from mod_ssl for the initialization phase.) Anyone who wants to enable the applink stub logic for mod_php or other weirdness is welcome to patch that either by 1) adding the applink.c to abs.exe and/or httpd.exe linkage, or the main() source file can #include that "<include/openssl/applink.c>". Anyone interested can proceed to patch both and provision applink.c when > working with OpenSSL 1.1.1, so I don't need to raise a ticket at that > project. > Regression #7396 <https://github.com/openssl/openssl/issues/7396> was fixed with 92ebf6c <https://github.com/openssl/openssl/commit/92ebf6c4c21ff4b41ba1fd69af74b2039e138114> for OpenSSL 1.1.1a. The oversight of dropping applink.c appears to have been unintended. Thanks to you all for your review and re-evaluation of the past and current situations with OpenSSL.
