I just found that this is a compile error on my mac w/ maintainer mode
due to __attribute__((nonnull))
util.c:576:10: error: nonnull parameter 'name' will evaluate to 'true'
on first encounter [-Werror,-Wpointer-bool-conversion]

    if (!name || !*name) {

On Mon, Mar 18, 2019 at 5:19 AM <[email protected]> wrote:
>
> Author: rpluem
> Date: Mon Mar 18 09:19:54 2019
> New Revision: 1855743
>
> URL: http://svn.apache.org/viewvc?rev=1855743&view=rev
> Log:
> * Play safe in case we get no name
>
> Modified:
>     httpd/httpd/trunk/server/util.c
>
> Modified: httpd/httpd/trunk/server/util.c
> URL: 
> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util.c?rev=1855743&r1=1855742&r2=1855743&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/server/util.c (original)
> +++ httpd/httpd/trunk/server/util.c Mon Mar 18 09:19:54 2019
> @@ -573,6 +573,10 @@ AP_DECLARE(void) ap_no2slash_ex(char *na
>
>      char *d, *s;
>
> +    if (!name || !*name) {
> +        return;
> +    }
> +
>      s = d = name;
>
>  #ifdef HAVE_UNC_PATHS
>
>


-- 
Eric Covener
[email protected]

Reply via email to