The question is, should our buildbot detect those things?
> Am 18.03.2019 um 13:46 schrieb Ruediger Pluem <[email protected]>:
>
>
>
> On 03/18/2019 01:42 PM, Ruediger Pluem wrote:
>>
>>
>> On 03/18/2019 01:22 PM, Eric Covener wrote:
>>> I just found that this is a compile error on my mac w/ maintainer mode
>>> due to __attribute__((nonnull))
>>> util.c:576:10: error: nonnull parameter 'name' will evaluate to 'true'
>>> on first encounter [-Werror,-Wpointer-bool-conversion]
>>
>> Hm. I guess my RedHat 6 compiler is too old and no maintainer mode used.
>> Hence I did not catch that.
>> So should we just revert r1855743 (unfortunately in 2.4.x then as well :-( )
>> and put the NULL checking
>> burden on the caller? I guess in the specific case here where it caused the
>> segfault we are safe
>> as r1855744 catches that.
>
> Ok, r1855755 is even better :-)
> Voted on it. Hopefully everything is fine now.
>
> Regards
>
> Rüdiger
>
>
