C2 General

> -----Ursprüngliche Nachricht-----
> Von: Yann Ylavic <ylavic....@gmail.com>
> Gesendet: Donnerstag, 9. Mai 2019 12:00
> An: httpd-dev <dev@httpd.apache.org>
> Betreff: Re: eor bucket
> 
> On Thu, May 9, 2019 at 11:54 AM Yann Ylavic <ylavic....@gmail.com>
> wrote:
> >
> > On Thu, May 9, 2019 at 11:37 AM Stefan Eissing
> > <stefan.eiss...@greenbytes.de> wrote:
> > >
> > > > Am 09.05.2019 um 11:32 schrieb Yann Ylavic <ylavic....@gmail.com>:
> > > >
> > > > The issue is more that the hooks in eor_bucket_cleanup() will be
> run
> > > > multiple times, rather than a lifetime issue.
> > >
> > > I read it like this:
> > > The cleanup is only registered on the first creation. The copy never
> registers. But the bucket_destroy calls the pool destroy each time.
> >
> > Ah yes, apr_bucket_copy() (i.e. apr_bucket_simple_copy()) won't do the
> > right thing for eor, there should be an eor_bucket_copy() to register
> > the cleanup for the copy too.
> >
> > We should also possibly split the eor cleanup in two, one (registered
> > first) to run the hooks, and the second for NULLing b->data.
> > Both (but mainly the first one) would do nothing is b->data is already
> > NULL. That way I think the eor can be safely copied.
> 
> Or, use the EOR bucket code from trunk...

Which is the MMAP/file pattern approach as I just noticed :-) Thanks for the 
pointer.

Regards

Rüdiger

Reply via email to