On Mon, Apr 27, 2020 at 03:57:37PM +0200, Yann Ylavic wrote: > On Mon, Apr 27, 2020 at 3:43 PM Yann Ylavic <[email protected]> wrote: > > > > On Mon, Apr 27, 2020 at 2:09 PM Yann Ylavic <[email protected]> wrote: > > > > > > https://github.com/apache/httpd/pull/117 > > > > I closed it, how about the second patch there though? > > > > https://github.com/apache/httpd/pull/117/commits/cdf4c4a3c61340f061267cc70c456d9469e9faac > > Actually the attached one (with no mention of morphing since we are > not talking about FILE buckets anymore). > I have chosen the term "opaque" because it's concise (e.g. > opaque_buckets_in_brigade), but it's just in comments now (and > accompanied by "(length == -1)" to specify what it means). The goal > being to axe AP_BUCKET_IS_MORPHING() which I introduced recently..
+1 from me for using the term "opaque buckets" as a synonym for "e->length == (apr_size_t)-1" aka "buckets with indeterminate length". Regards, Joe
