On Mon, Apr 27, 2020 at 04:27:56PM +0200, Yann Ylavic wrote: > On Mon, Apr 27, 2020 at 4:11 PM Joe Orton <[email protected]> wrote: > > > > +1 from me for using the term "opaque buckets" as a synonym for > > "e->length == (apr_size_t)-1" aka "buckets with indeterminate length". > > OK thanks, just committed "something" in r1877077 because I keep > messing up with my attachments today. > Let's discuss from "that" if needed..
That change is definitely better. Isn't the code still making the assumption that FILE is the only possible non-opaque morphing bucket type? http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_filter.c?revision=1877077&view=markup#l1108 ...and by "non-opaque morphing bucket type" the distinction intended here is... "representing a determinate length bucket type which is not fully mapped into RAM until you try read()ing it until exhaustion". (!)
