On Mon, Jan 24, 2022 at 1:30 PM Yann Ylavic <ylavic....@gmail.com> wrote:
>
> On Sun, Jan 23, 2022 at 10:16 PM <minf...@apache.org> wrote:
> >
> > --- httpd/httpd/trunk/modules/ssl/mod_ssl.c (original)
> > +++ httpd/httpd/trunk/modules/ssl/mod_ssl.c Sun Jan 23 21:16:06 2022
> > @@ -723,17 +723,37 @@ static int ssl_hook_process_connection(c
> >
> > if (rv == APR_SUCCESS) {
> > /* great news, lets continue */
> > +
> > + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(10370)
> > + "SSL handshake completed, continuing");
> > +
> > status = DECLINED;
> > }
> > else if (rv == APR_EAGAIN) {
> > /* we've been asked to come around again, don't block */
> > - status = OK;
> > +
> > + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(10371)
> > + "SSL handshake in progress, continuing");
> > +
> > + status = OK;
> > + }
> > + else if (rv == APR_EGENERAL) {
> > + /* handshake error, but mod_ssl handled it */
> > +
> > + ap_log_cerror(APLOG_MARK, APLOG_DEBUG, 0, c, APLOGNO(10372)
> > + "SSL handshake failed, returning error
> > response");
> > +
> > + status = DECLINED;
> > }
> > else {
> > /* we failed, give up */
> >
> > cs->state = CONN_STATE_LINGER;
> >
> > + ap_log_cerror(APLOG_MARK, APLOG_ERR, rv, c, APLOGNO(10373)
> > + "SSL handshake was not completed, "
> > + "closing connection");
> > +
> > status = OK;
> > }
> > }
>
> Why is APR_EGENERAL a special error, didn't mod_ssl handle the other errors
> too?
> Is this about special HTTP_SPOKEN_ON_HTTPS error handling?
I mean not only mod_ssl could return an error for
ap_get_brigade(AP_MODE_INIT), APR_EGENERAL is not distinctive enough
IMHO.
>
>
> Regards;
> Yann.
