On Mon, Jan 24, 2022 at 3:56 PM Graham Leggett <minf...@sharp.fm> wrote: > > On 24 Jan 2022, at 16:45, Yann Ylavic <ylavic....@gmail.com> wrote: > > >> True - changed to AP_FILTER_ERROR in r1897418, which is the correct code > >> for this. > > > > Would it work if ssl_hook_process_connection() handled only EAGAIN and > > otherwise always returned DECLINED (expecting that the usual > > processing would re-catch the error and still behave correctly)? > > It’s not ideal. > > This means on error, we would then attempt to read again (this time a > blocking read), and then possibly error again (but maybe not).
Yes, but it could be the duty of mod_ssl to not let further reading succeed if the handshake failed (which may be the case already).
