Hi Vino, Big +1 for this initiative. I have done this code cleanup for test classes in the past and strongly feel there is a need to do the same at other places as well. I would definitely like to volunteer for this.
On Tue, Jan 21, 2020 at 1:52 PM vino yang <yanghua1...@gmail.com> wrote: > Hi folks, > > Currently, the code quality of some Hudi module is not very well. As many > developers have seen, the Intellij IDEA has shown many intellisense about > cleanup and improvement. The community does not object to doing the cleanup > and improvement work and the work has been started via some direct "minor" > PRs by some volunteers. The current way is unorganized and hard to manage. > For tracking this work, I prefer to manage this work with the Jira issue. > We can create an umbrella issue. Then, split the work into several > subtasks. > > Since those "bad smell" lays anywhere in the whole project. It's difficult > to give a standard to split the subtasks. For example, some files have a > lot while some modules have few. So I suggest the standard would depend on > the volume of the changes. Before working, any subtask should find a > committer as a mentor who would judge and approve the scope is suitable. > > What do you think? > > Any comments and suggestions would be appreciated. > > Best, > Vino >
