Good job! thanks for adding. On Fri, Feb 28, 2020 at 5:41 PM vino yang <[email protected]> wrote:
> Hi Ram, > > Thanks for your great work to make the code coverage clear. > > Best, > Vino > > Vinoth Chandar <[email protected]> 于2020年2月29日周六 上午4:39写道： > > > Thanks Ram! This will definitely help improve the code quality over time! > > > > On Fri, Feb 28, 2020 at 9:45 AM Ramachandran Madras Subramaniam > > <[email protected]> wrote: > > > > > Hi everyone, > > > > > > Diff 1347 <https://github.com/apache/incubator-hudi/pull/1347> was > > merged > > > into master yesterday. This enables visibility into code coverage of > hudi > > > in general and also provides insights into differential coverage during > > > peer reviews. > > > > > > Since this is very recent and is getting integrated, you might see some > > > partial results in your diff. There can be 2 scenarios here, > > > > > > 1. Your diff is not rebased with latest master and hence the code > > coverage > > > report was not generated. To solve this issue, you just have to rebase > to > > > latest master. > > > 2. Code coverage ran but reported as zero. Three was one diff (#1350) > > where > > > we saw this issue yesterday. This in general shouldn't happen. Could > have > > > been due to an outage in codecov website. I will be monitoring upcoming > > > diffs for the near future to see if this problem persists. Please ping > me > > > in the diff if you have any questions/concerns regarding code coverage. > > > > > > Thanks, > > > Ram > > > > > > -- Regards, -Sivabalan
