Thank you all for your kind words :) An update on the issues. I am still seeing some PRs reporting zero coverage for the forked branch and hence a drop of 60%+ coverage. Opened a ticket with codecov <https://community.codecov.io/t/pr-reporting-very-low-coverage-and-hence-a-huge-decrease-in-coverage/1098> today to understand this issue better.
Also you might see some of the PRs not pulling up any coverage for master. This is due to the fact that those PRs have not rebased to current master and have opened the diff against an older commit in master which doesn't have any data in codecov. This should go away if these PRs are rebased. It is not mandatory to rebase as of now as this problem will fade away eventually on new PRs. -Ram On Sun, Mar 1, 2020 at 8:20 PM Bhavani Sudha <[email protected]> wrote: > This is super useful. Thanks Ramachandran! > > -Sudha > > On Sat, Feb 29, 2020 at 7:42 PM leesf <[email protected]> wrote: > > > Great job, thanks for your work. > > > > Sivabalan <[email protected]> 于2020年2月29日周六 下午12:02写道： > > > > > Good job! thanks for adding. > > > > > > On Fri, Feb 28, 2020 at 5:41 PM vino yang <[email protected]> > wrote: > > > > > > > Hi Ram, > > > > > > > > Thanks for your great work to make the code coverage clear. > > > > > > > > Best, > > > > Vino > > > > > > > > Vinoth Chandar <[email protected]> 于2020年2月29日周六 上午4:39写道： > > > > > > > > > Thanks Ram! This will definitely help improve the code quality over > > > time! > > > > > > > > > > On Fri, Feb 28, 2020 at 9:45 AM Ramachandran Madras Subramaniam > > > > > <[email protected]> wrote: > > > > > > > > > > > Hi everyone, > > > > > > > > > > > > Diff 1347 < > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_apache_incubator-2Dhudi_pull_1347&d=DwIFaQ&c=r2dcLCtU9q6n0vrtnDw9vg&r=KLmNyF_KPBPNb-BIVUsy8j_1tYfqyNa57jwVia1c9kM&m=SS0RbqE858fB7dZFTDERnraMoIystkopIUY-jADgVHs&s=LWGjgAlb8k98t_HYrdUbYZ-rjQhDfVPRUYzXafRsJNA&e= > > was > > > > > merged > > > > > > into master yesterday. This enables visibility into code coverage > > of > > > > hudi > > > > > > in general and also provides insights into differential coverage > > > during > > > > > > peer reviews. > > > > > > > > > > > > Since this is very recent and is getting integrated, you might > see > > > some > > > > > > partial results in your diff. There can be 2 scenarios here, > > > > > > > > > > > > 1. Your diff is not rebased with latest master and hence the code > > > > > coverage > > > > > > report was not generated. To solve this issue, you just have to > > > rebase > > > > to > > > > > > latest master. > > > > > > 2. Code coverage ran but reported as zero. Three was one diff > > (#1350) > > > > > where > > > > > > we saw this issue yesterday. This in general shouldn't happen. > > Could > > > > have > > > > > > been due to an outage in codecov website. I will be monitoring > > > upcoming > > > > > > diffs for the near future to see if this problem persists. Please > > > ping > > > > me > > > > > > in the diff if you have any questions/concerns regarding code > > > coverage. > > > > > > > > > > > > Thanks, > > > > > > Ram > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Regards, > > > -Sivabalan > > > > > >
