+1 (not binding) - ran `mvn clean package -DskipTests` [OK] - ran all QuickStart demos (HDFS) [OK] - some unit test locally [OK] - tested flink write client in cluster [OK]
Best wangxianghu > 2021年1月25日 下午3:03,vino yang <yanghua1...@gmail.com> 写道: > > +1 binding > > - ran `mvn clean package -DskipTests` [OK] > - ran QuickStart [OK] > - checked signature and checksum [OK] > - tested flink write client in local [OK] > > Best, > Vino > > leesf <leesf0...@gmail.com> 于2021年1月24日周日 下午8:30写道: > >> +1 binding >> >> - Build successful >> - Ran quickstart successful. >> - Additional manual testing with and without Metadata based listing enabled >> for COW and MOR table against aliyun OSS. >> >> Sivabalan <n.siv...@gmail.com> 于2021年1月23日周六 下午9:55写道: >> >>> Got it, I didn't do -1, but just wanted to remind you, so that you don't >>> miss it when you redo the steps again to promote the final one. >>> >>> +1 binding. >>> But do ensure when you release, the staged repo (promoted candidate) has >>> only one set of artifacts and it's a new repo. >>> >>> >>> On Sat, Jan 23, 2021 at 2:03 AM nishith agarwal <n3.nas...@gmail.com> >>> wrote: >>> >>>> +1 binding >>>> >>>> - Build Successful >>>> - Release validation script Successful >>>> - Quick start runs Successfully >>>> >>>> Checking Checksum of Source Release >>>> Checksum Check of Source Release - [OK] >>>> >>>> % Total % Received % Xferd Average Speed Time Time Time >>>> Current >>>> Dload Upload Total Spent Left >>>> Speed >>>> 100 34972 100 34972 0 0 96076 0 --:--:-- --:--:-- >> --:--:-- >>>> 96076 >>>> Checking Signature >>>> Signature Check - [OK] >>>> >>>> Checking for binary files in source release >>>> No Binary Files in Source Release? - [OK] >>>> >>>> Checking for DISCLAIMER >>>> DISCLAIMER file exists ? [OK] >>>> >>>> Checking for LICENSE and NOTICE >>>> License file exists ? [OK] >>>> Notice file exists ? [OK] >>>> >>>> Performing custom Licensing Check >>>> Licensing Check Passed [OK] >>>> >>>> Running RAT Check >>>> RAT Check Passed [OK] >>>> >>>> Thanks, >>>> Nishith >>>> >>>> On Fri, Jan 22, 2021 at 9:28 PM Vinoth Chandar <vin...@apache.org> >>> wrote: >>>> >>>>> Thanks Siva! I am not sure if thats a required aspect for the binding >>>> vote. >>>>> Its a minor aspect that does not interfere with testing/validation in >>>>> anyway. The actual release artifact needs to be rebuilt and repushed >>>> anyway >>>>> from a separate repo. Like I noted, I found the wiki instructions bit >>>>> ambiguous and I intend to make it clearer going forward so we can >> avoid >>>>> this in future. >>>>> >>>>> I request everyone to consider this explanation, when casting your >>> vote. >>>>> >>>>> Thanks >>>>> Vinoth >>>>> >>>>> >>>>> On Fri, Jan 22, 2021 at 8:35 PM Sivabalan <n.siv...@gmail.com> >> wrote: >>>>> >>>>>> - checksums and signatures [OK] >>>>>> - successfully built [OK] >>>>>> - ran quick start guide [OK] >>>>>> - Ran release validation guide [OK] >>>>>> - Ran test suite job w/ inserts, upserts, deletes and >>> validation(spark >>>>> sql >>>>>> and hive). Also same job w/ metadata enabled as well [OK] >>>>>> >>>>>> - Artifacts in staging repo : should be in separate repo where only >>> rc2 >>>>> is >>>>>> present. Right now, I see both rc1 and rc2 are present in the same >>>> repo. >>>>>> >>>>>> Will add my binding vote once artifacts are fixed. >>>>>> >>>>>> >>>>>> >>>>>> On Fri, Jan 22, 2021 at 9:17 PM Udit Mehrotra <udi...@apache.org> >>>> wrote: >>>>>> >>>>>>> +1 >>>>>>> - Build successful >>>>>>> - Ran quickstart against S3 >>>>>>> - Additional manual tests with MOR >>>>>>> - Additional manual testing with and without Metadata based >> listing >>>>>> enabled >>>>>>> - Release validation script successful >>>>>>> >>>>>>> Validating hudi-0.7.0-rc2 with release type "dev" >>>>>>> Checking Checksum of Source Release >>>>>>> -e Checksum Check of Source Release - [OK] >>>>>>> >>>>>>> % Total % Received % Xferd Average Speed Time Time >>>> Time >>>>>>> Current >>>>>>> Dload Upload Total Spent >>>> Left >>>>>>> Speed >>>>>>> 100 34972 100 34972 0 0 70937 0 --:--:-- --:--:-- >>>>> --:--:-- >>>>>>> 70793 >>>>>>> Checking Signature >>>>>>> -e Signature Check - [OK] >>>>>>> >>>>>>> Checking for binary files in source release >>>>>>> -e No Binary Files in Source Release? - [OK] >>>>>>> >>>>>>> Checking for DISCLAIMER >>>>>>> -e DISCLAIMER file exists ? [OK] >>>>>>> >>>>>>> Checking for LICENSE and NOTICE >>>>>>> -e License file exists ? [OK] >>>>>>> -e Notice file exists ? [OK] >>>>>>> >>>>>>> Performing custom Licensing Check >>>>>>> -e Licensing Check Passed [OK] >>>>>>> >>>>>>> Running RAT Check >>>>>>> -e RAT Check Passed [OK] >>>>>>> >>>>>>> Thanks, >>>>>>> Udit >>>>>>> >>>>>>> On Fri, Jan 22, 2021 at 12:41 PM Vinoth Chandar < >> vin...@apache.org >>>> >>>>>> wrote: >>>>>>> >>>>>>>> Hi everyone, >>>>>>>> >>>>>>>> Please review and vote on the release candidate #2 for the >>> version >>>>>> 0.7.0, >>>>>>>> as follows: >>>>>>>> >>>>>>>> [ ] +1, Approve the release >>>>>>>> >>>>>>>> [ ] -1, Do not approve the release (please provide specific >>>> comments) >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> The complete staging area is available for your review, which >>>>> includes: >>>>>>>> >>>>>>>> * JIRA release notes [1], >>>>>>>> >>>>>>>> * the official Apache source release and binary convenience >>>> releases >>>>> to >>>>>>> be >>>>>>>> deployed to dist.apache.org [2], which are signed with the key >>>> with >>>>>>>> fingerprint 7F2A3BEB922181B06ACB1AA45F7D09E581D2BCB6 [3], >>>>>>>> >>>>>>>> * all artifacts to be deployed to the Maven Central Repository >>> [4], >>>>>>>> >>>>>>>> * source code tag "release-0.7.0-rc2" [5], >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> The vote will be open for at least 72 hours. It is adopted by >>>>> majority >>>>>>>> approval, with at least 3 PMC affirmative votes. >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> Release Manager >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> [1] >>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12322822&version=12348721 >>>>>>>> >>>>>>>> >>>>>>>> [2] >> https://dist.apache.org/repos/dist/dev/hudi/hudi-0.7.0-rc2/ >>>>>>>> >>>>>>>> [3] https://dist.apache.org/repos/dist/release/hudi/KEYS >>>>>>>> >>>>>>>> [4] >>>>>>> >>>> https://repository.apache.org/content/repositories/orgapachehudi-1027/ >>>>>>>> >>>>>>>> [5] https://github.com/apache/hudi/tree/release-0.7.0-rc2 >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> -Sivabalan >>>>>> >>>>> >>>> >>> >>> >>> -- >>> Regards, >>> -Sivabalan >>> >> >