javeme commented on code in PR #1847:
URL:
https://github.com/apache/incubator-hugegraph/pull/1847#discussion_r861443300
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -1059,13 +1059,12 @@ private boolean match(int expected) {
@SuppressWarnings("unused")
private void dump() {
this.seek();
- LOG.info(">>>> scan from " + this.table + ": " +
+ LOG.info(">>>> scan from {}: {}{}", this.table,
(this.keyBegin == null ? "*" :
- StringEncoding.format(this.keyBegin)) +
+ StringEncoding.format(this.keyBegin)),
(this.iter.isValid() ? "" : " - No data"));
for (; this.iter.isValid(); this.iter.next()) {
- LOG.info(StringEncoding.format(this.iter.key()) +
- "=" +
+ LOG.info("{}={}",StringEncoding.format(this.iter.key()),
Review Comment:
```java
LOG.info("{}={}",
StringEncoding.format(this.iter.key()),
StringEncoding.format(this.iter.value()));
```
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -1059,13 +1059,12 @@ private boolean match(int expected) {
@SuppressWarnings("unused")
private void dump() {
this.seek();
- LOG.info(">>>> scan from " + this.table + ": " +
+ LOG.info(">>>> scan from {}: {}{}", this.table,
(this.keyBegin == null ? "*" :
- StringEncoding.format(this.keyBegin)) +
+ StringEncoding.format(this.keyBegin)),
Review Comment:
```java
LOG.info(">>>> scan from {}: {}{}",
this.table,
this.keyBegin == null ? "*" : StringEncoding.format(this.keyBegin),
this.iter.isValid() ? "" : " - No data"));
```
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBOptions.java:
##########
@@ -168,8 +168,8 @@ public static synchronized RocksDBOptions instance() {
public static final ConfigOption<Integer> MAX_BG_JOBS =
new ConfigOption<>(
"rocksdb.max_background_jobs",
- "Maximum number of concurrent background jobs," +
- " including flushes and compactions.",
+ "Maximum number of concurrent background jobs, " +
+ "including flushes and compactions.",
Review Comment:
align with "Maximum number..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
