javeme commented on code in PR #1847:
URL:
https://github.com/apache/incubator-hugegraph/pull/1847#discussion_r861738515
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -1058,14 +1059,14 @@ private boolean match(int expected) {
@SuppressWarnings("unused")
private void dump() {
this.seek();
- System.out.println(">>>> scan from " + this.table + ": " +
- (this.keyBegin == null ? "*" :
- StringEncoding.format(this.keyBegin)) +
- (this.iter.isValid() ? "" : " - No data"));
+ LOG.info(">>>> scan from {}: {}{}",
+ this.table,
+ this.keyBegin == null ? "*" :
StringEncoding.format(this.keyBegin),
+ this.iter.isValid() ? "" : " - No data"));
Review Comment:
`" - No data"))` => `" - No data")`
there is an error:
`/home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:1065:61:
expecting RCURLY, found ')' -> [Help 1]`
##########
hugegraph-rocksdb/src/main/java/com/baidu/hugegraph/backend/store/rocksdb/RocksDBStdSessions.java:
##########
@@ -1058,14 +1059,14 @@ private boolean match(int expected) {
@SuppressWarnings("unused")
private void dump() {
this.seek();
- System.out.println(">>>> scan from " + this.table + ": " +
- (this.keyBegin == null ? "*" :
- StringEncoding.format(this.keyBegin)) +
- (this.iter.isValid() ? "" : " - No data"));
+ LOG.info(">>>> scan from {}: {}{}",
+ this.table,
Review Comment:
align with `">>>>`?
code style:
https://github.com/apache/incubator-hugegraph-doc/wiki/HugeGraph%E4%BB%A3%E7%A0%81%E9%A3%8E%E6%A0%BC%E6%8C%87%E5%8D%97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
