javeme commented on code in PR #1858:
URL:
https://github.com/apache/incubator-hugegraph/pull/1858#discussion_r865545000
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/InitStore.java:
##########
@@ -47,15 +47,15 @@ public class InitStore {
// Less than 5000 may cause mismatch exception with Cassandra backend
private static final long RETRY_INTERVAL = 5000;
- private static final MultiValueMap exceptions = new MultiValueMap();
+ private static final MultiValueMap EXCEPTION = new MultiValueMap();
Review Comment:
can keep "EXCEPTIONS" name
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/StoreDumper.java:
##########
@@ -51,10 +56,10 @@ public void dump(HugeType table, long offset, long limit) {
}
String title = String.format("Dump table %s (offset %d limit %d):",
table, offset, limit);
- System.out.println(title);
+ LOG.info("title : {}",title);
Review Comment:
merge into line 57
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/StoreDumper.java:
##########
@@ -51,10 +56,10 @@ public void dump(HugeType table, long offset, long limit) {
}
String title = String.format("Dump table %s (offset %d limit %d):",
table, offset, limit);
- System.out.println(title);
+ LOG.info("title : {}",title);
for (long i = 0; i < limit && rs.hasNext(); i++) {
BackendEntry entry = rs.next();
- System.out.println(entry);
+ LOG.info("entry : {}",entry);
Review Comment:
`LOG.info("{}" entry)` is ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
