imbajin commented on code in PR #1858:
URL:
https://github.com/apache/incubator-hugegraph/pull/1858#discussion_r865780273
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/StoreDumper.java:
##########
@@ -22,21 +22,26 @@
import java.util.Iterator;
import org.apache.tinkerpop.gremlin.structure.util.CloseableIterator;
+import org.slf4j.Logger;
import com.baidu.hugegraph.HugeFactory;
import com.baidu.hugegraph.HugeGraph;
import com.baidu.hugegraph.backend.query.Query;
import com.baidu.hugegraph.backend.store.BackendEntry;
import com.baidu.hugegraph.backend.store.BackendStore;
import com.baidu.hugegraph.dist.RegisterUtil;
+import com.baidu.hugegraph.server.RestServer;
import com.baidu.hugegraph.testutil.Whitebox;
import com.baidu.hugegraph.type.HugeType;
import com.baidu.hugegraph.util.E;
+import com.baidu.hugegraph.util.Log;
public class StoreDumper {
private final HugeGraph graph;
+ private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
same warning
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/ConfDumper.java:
##########
@@ -25,26 +25,32 @@
import org.apache.commons.configuration.ConfigurationException;
import org.apache.commons.io.FileUtils;
+import org.slf4j.Logger;
import com.baidu.hugegraph.config.HugeConfig;
import com.baidu.hugegraph.config.OptionSpace;
import com.baidu.hugegraph.config.TypedOption;
import com.baidu.hugegraph.dist.RegisterUtil;
+import com.baidu.hugegraph.server.RestServer;
import com.baidu.hugegraph.util.E;
+import com.baidu.hugegraph.util.Log;
public class ConfDumper {
public static final String EOL = System.getProperty("line.separator");
+ private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
use `RestServer` name for the class's log?
##########
hugegraph-dist/src/main/java/com/baidu/hugegraph/cmd/ConfDumper.java:
##########
@@ -25,26 +25,32 @@
import org.apache.commons.configuration.ConfigurationException;
import org.apache.commons.io.FileUtils;
+import org.slf4j.Logger;
import com.baidu.hugegraph.config.HugeConfig;
import com.baidu.hugegraph.config.OptionSpace;
import com.baidu.hugegraph.config.TypedOption;
import com.baidu.hugegraph.dist.RegisterUtil;
+import com.baidu.hugegraph.server.RestServer;
import com.baidu.hugegraph.util.E;
+import com.baidu.hugegraph.util.Log;
public class ConfDumper {
public static final String EOL = System.getProperty("line.separator");
+ private static final Logger LOG = Log.logger(RestServer.class);
Review Comment:
use `RestServer` name for the class's log? (just ensure it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
