imbajin commented on code in PR #385:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/385#discussion_r1033324131
##########
hugegraph-dist/release-docs/licenses/LICENSE-ant-launcher.txt:
##########
@@ -202,7 +202,7 @@
* limitations under the License.
*/
-W3C� SOFTWARE NOTICE AND LICENSE
+W3C� SOFTWARE NOTICE AND LICENSE
Review Comment:
seems wrong?
##########
hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java:
##########
@@ -54,6 +58,7 @@ public static ServerException fromResponse(Response response)
{
exception.cause = (String) getByKeys(json, CAUSE_KEYS);
exception.trace = getByKeys(json, TRACE_KEYS);
} catch (Exception ignored) {
+ LOG.error(" ServerException excepiton ");
Review Comment:
we need log here? @javeme
and seems have 2 extra spaces
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/service/load/LoadTaskService.java:
##########
@@ -436,7 +436,8 @@ private FileSource buildFileSource(FileMapping fileMapping)
{
Ex.check(idFields.size() == 1,
"When the ID strategy is CUSTOMIZED, you must " +
"select a column in the file as the id");
- vMapping = new
org.apache.hugegraph.loader.mapping.VertexMapping(idFields.get(0), true);
+ vMapping = new
org.apache.hugegraph.loader.mapping.VertexMapping(
+ idFields.get(0), true);
Review Comment:
if line < 100, use one line instead
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java:
##########
@@ -183,18 +183,18 @@ private void flush(ElementBuilder<GraphElement>
elementBuilder, List<String> row
Map<String, UpdateStrategy> updateStrategyMap =
elementMapping.updateStrategies();
if (isVertex) {
- BatchVertexRequest.Builder req = new
BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .createIfNotExist(true);
- g.updateVertices(req.build());
+ BatchVertexRequest.Builder request = new
BatchVertexRequest.Builder();
+ request.vertices((List<Vertex>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
+ .createIfNotExist(true);
+ g.updateVertices(request.build());
} else {
- BatchEdgeRequest.Builder req = new
BatchEdgeRequest.Builder();
- req.edges((List<Edge>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .checkVertex(this.loadOptions.checkVertex)
- .createIfNotExist(true);
- g.updateEdges(req.build());
+ BatchEdgeRequest.Builder request = new
BatchEdgeRequest.Builder();
+ request.edges((List<Edge>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
+ .checkVertex(this.loadOptions.checkVertex)
+ .createIfNotExist(true);
Review Comment:
seems one extra space?
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java:
##########
@@ -57,6 +61,7 @@ public HugeConfig hugeConfig() {
conf = path;
}
} catch (Exception ignored) {
+ LOG.error("hugeConfig exception");
Review Comment:
same question
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java:
##########
@@ -309,19 +309,19 @@ private void flush(Map.Entry<ElementBuilder,
List<GraphElement>> builderMap,
} else {
// CreateIfNotExist doesn't support false now
if (isVertex) {
- BatchVertexRequest.Builder req =
+ BatchVertexRequest.Builder request =
new BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .createIfNotExist(true);
- g.updateVertices(req.build());
+ request.vertices((List<Vertex>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
+ .createIfNotExist(true);
Review Comment:
align problem?
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/spark/HugeGraphSparkLoader.java:
##########
@@ -309,19 +309,19 @@ private void flush(Map.Entry<ElementBuilder,
List<GraphElement>> builderMap,
} else {
// CreateIfNotExist doesn't support false now
if (isVertex) {
- BatchVertexRequest.Builder req =
+ BatchVertexRequest.Builder request =
new BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .createIfNotExist(true);
- g.updateVertices(req.build());
+ request.vertices((List<Vertex>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
+ .createIfNotExist(true);
+ g.updateVertices(request.build());
} else {
- BatchEdgeRequest.Builder req = new BatchEdgeRequest.Builder();
- req.edges((List<Edge>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .checkVertex(isCheckVertex)
- .createIfNotExist(true);
- g.updateEdges(req.build());
+ BatchEdgeRequest.Builder request = new
BatchEdgeRequest.Builder();
+ request.edges((List<Edge>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
+ .checkVertex(isCheckVertex)
+ .createIfNotExist(true);
Review Comment:
same, and why we change the name? (seems optional)
##########
hugegraph-dist/release-docs/licenses/LICENSE-ant.txt:
##########
@@ -202,7 +202,7 @@
* limitations under the License.
*/
-W3C� SOFTWARE NOTICE AND LICENSE
+W3C� SOFTWARE NOTICE AND LICENSE
Review Comment:
same
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java:
##########
@@ -127,20 +127,20 @@ protected void updateBatch(List<Record> batch, boolean
checkVertex) {
batch.forEach(r -> elements.add(r.element()));
// CreateIfNotExist does not support false now
if (this.type().isVertex()) {
- BatchVertexRequest.Builder req = new BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) elements)
- .updatingStrategies(this.mapping.updateStrategies())
- .createIfNotExist(true);
+ BatchVertexRequest.Builder request = new
BatchVertexRequest.Builder();
+ request.vertices((List<Vertex>) (Object) elements)
+ .updatingStrategies(this.mapping.updateStrategies())
+ .createIfNotExist(true);
Review Comment:
same, and so as others
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
