javeme commented on code in PR #385:
URL:
https://github.com/apache/incubator-hugegraph-toolchain/pull/385#discussion_r1034991849
##########
hugegraph-client/src/main/java/org/apache/hugegraph/exception/ServerException.java:
##########
@@ -24,11 +24,15 @@
import org.apache.hugegraph.rest.RestResult;
import jakarta.ws.rs.core.Response;
+import org.apache.hugegraph.util.Log;
+import org.slf4j.Logger;
public class ServerException extends RuntimeException {
private static final long serialVersionUID = 6335623004322652358L;
+ protected static final Logger LOG = Log.logger(ServerException.class);
Review Comment:
mark as private?
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/flink/HugeGraphOutputFormat.java:
##########
@@ -183,18 +183,18 @@ private void flush(ElementBuilder<GraphElement>
elementBuilder, List<String> row
Map<String, UpdateStrategy> updateStrategyMap =
elementMapping.updateStrategies();
if (isVertex) {
- BatchVertexRequest.Builder req = new
BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) graphElements)
- .updatingStrategies(updateStrategyMap)
- .createIfNotExist(true);
- g.updateVertices(req.build());
+ BatchVertexRequest.Builder request = new
BatchVertexRequest.Builder();
+ request.vertices((List<Vertex>) (Object) graphElements)
+ .updatingStrategies(updateStrategyMap)
Review Comment:
align with '.'
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java:
##########
@@ -127,20 +127,20 @@ protected void updateBatch(List<Record> batch, boolean
checkVertex) {
batch.forEach(r -> elements.add(r.element()));
// CreateIfNotExist does not support false now
if (this.type().isVertex()) {
- BatchVertexRequest.Builder req = new BatchVertexRequest.Builder();
- req.vertices((List<Vertex>) (Object) elements)
- .updatingStrategies(this.mapping.updateStrategies())
- .createIfNotExist(true);
+ BatchVertexRequest.Builder request = new
BatchVertexRequest.Builder();
+ request.vertices((List<Vertex>) (Object) elements)
+ .updatingStrategies(this.mapping.updateStrategies())
+ .createIfNotExist(true);
- client.graph().updateVertices(req.build());
+ client.graph().updateVertices(request.build());
} else {
- BatchEdgeRequest.Builder req = new BatchEdgeRequest.Builder();
- req.edges((List<Edge>) (Object) elements)
- .updatingStrategies(this.mapping.updateStrategies())
- .checkVertex(checkVertex)
- .createIfNotExist(true);
+ BatchEdgeRequest.Builder request = new BatchEdgeRequest.Builder();
+ request.edges((List<Edge>) (Object) elements)
+ .updatingStrategies(this.mapping.updateStrategies())
Review Comment:
ditto
##########
hugegraph-hubble/hubble-be/src/main/java/org/apache/hugegraph/config/HubbleConfig.java:
##########
@@ -33,6 +35,8 @@
@Configuration
public class HubbleConfig {
+ protected static final Logger LOG = Log.logger(HubbleConfig.class);
Review Comment:
ditto
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/task/InsertTask.java:
##########
@@ -48,9 +48,9 @@ public abstract class InsertTask implements Runnable {
public static final String[] UNACCEPTABLE_MESSAGES = {
// org.apache.http.conn.HttpHostConnectException
- "Connection refused",
- "The server is being shutting down",
- "not allowed to insert, because already exist a vertex " +
+ "Connection refused",
+ "The server is being shutting down",
+ "not allowed to insert, because already exist a vertex " +
Review Comment:
keep the origin style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
