mccheah commented on a change in pull request #14: Pluggable file I/O submodule
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240410990
##########
File path:
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -91,7 +91,7 @@ public TableMetadata refresh() {
}
this.version = ver;
this.currentMetadata = TableMetadataParser.read(this,
- HadoopInputFile.fromPath(metadataFile, conf));
+ fileIo().newInputFile(metadataFile.toString()));
Review comment:
I also think it's reasonable for `FileIO` to accept `URI` objects as
arguments instead of just `String`s. That gives a stronger opinion about what
these paths are as well. Then we call `Path#toUri` and go from there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
