mccheah commented on a change in pull request #14: Pluggable file I/O submodule 
in TableOperations
URL: https://github.com/apache/incubator-iceberg/pull/14#discussion_r240423935
 
 

 ##########
 File path: 
core/src/main/java/com/netflix/iceberg/hadoop/HadoopTableOperations.java
 ##########
 @@ -91,7 +91,7 @@ public TableMetadata refresh() {
     }
     this.version = ver;
     this.currentMetadata = TableMetadataParser.read(this,
-        HadoopInputFile.fromPath(metadataFile, conf));
+        fileIo().newInputFile(metadataFile.toString()));
 
 Review comment:
   In the interest of keeping the API surface area smaller and with higher 
order abstractions, will keep this as `toString`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to