+1 (binding) - Ran license checks (dev/check-license) - Validated signature and checksum - Built and ran tests with Flink 1.17 and Spark 3.5 in Java 11 - Ran queries in Spark 3.5 with the iceberg-aws-bundle providing S3 dependencies - Checked CI tests are all passing
On Sun, Oct 1, 2023 at 1:53 AM Ajantha Bhat <ajanthab...@gmail.com> wrote: > +1 (non-binding) > > - Verified Nessie integration testing (API v2 and V1) with > Spark-3.3_2.12_runtime jar. > - Validated checksum and signature > - Checked license docs & ran RAT checks > - Verified build with JDK11 > > > @Dan: > Flink test failure with Java 17 is tracked from > https://github.com/apache/iceberg/issues/8680 > and it seems Flink doesn't officially support Java 17 in the current > Iceberg integrated versions. > So, we are good to go I guess. > > Thanks, > Ajantha > > On Sun, Oct 1, 2023 at 3:45 AM Daniel Weeks <dwe...@apache.org> wrote: > >> +1 (binding) >> >> Verified sigs/sums/license/build/test >> >> Using Java 17 I had failures in Flink tests (seems isolated to the Flink >> test framework, so not a blocker): >> TestIcebergSourceFailover > testBoundedWithTaskManagerFailover FAILED >> java.lang.IllegalAccessError: class org.apache.flink.util.NetUtils >> (in unnamed module @0x37858383) cannot access class >> sun.net.util.IPAddressUtil (in module java.base) because module java.base >> does not export sun.net.util to unnamed module @0x37858383 >> >> However, these passed when I switched to Java 8 >> >> I also performed some manual validation using Spark 3.5. >> >> Looks good! >> -Dan >> >> >> On Sat, Sep 30, 2023 at 12:13 PM Hussein Awala <huss...@awala.fr> wrote: >> >>> +1 (non-binding) I tested it with Spark 3.3, all looks good. >>> >>> On Sat, Sep 30, 2023 at 9:04 PM Bryan Keller <brya...@gmail.com> wrote: >>> >>>> +1 (non-binding) >>>> >>>> I reran the TPC-DS benchmark with RC2, with the same setup as with RC1, >>>> and there were no warnings about decimal pushdown, so that appears >>>> resolved. The results were also a bit better at 4915 sec. >>>> >>>> -Bryan >>>> >>>> On Fri, Sep 29, 2023 at 10:37 PM Anton Okolnychyi < >>>> aokolnyc...@apache.org> wrote: >>>> >>>>> +1 (binding) >>>>> >>>>> Validated signature, checksum, local build + tests. >>>>> >>>>> - Anton >>>>> >>>>> On 2023/09/30 04:58:15 Jean-Baptiste Onofré wrote: >>>>> > +1 (non binding) >>>>> > >>>>> > As for RC1, I checked: >>>>> > - signature and hash are OK >>>>> > - ASF headers are there >>>>> > - source distribution doesn't contain binary >>>>> > - build is OK >>>>> > >>>>> > Thanks, >>>>> > Regards >>>>> > JB >>>>> > >>>>> > On Sat, Sep 30, 2023 at 1:25 AM Anton Okolnychyi >>>>> > <aokolnyc...@apple.com.invalid> wrote: >>>>> > > >>>>> > > Hi Everyone, >>>>> > > >>>>> > > I propose that we release the following RC as the official Apache >>>>> Iceberg 1.4.0 release. >>>>> > > >>>>> > > The commit ID is 10367c380098c2e06a49521a33681ac7f6c64b2c >>>>> > > * This corresponds to the tag: apache-iceberg-1.4.0-rc2 >>>>> > > * >>>>> https://github.com/apache/iceberg/commits/apache-iceberg-1.4.0-rc2 >>>>> > > * >>>>> https://github.com/apache/iceberg/tree/10367c380098c2e06a49521a33681ac7f6c64b2c >>>>> > > >>>>> > > The release tarball, signature, and checksums are here: >>>>> > > * >>>>> https://dist.apache.org/repos/dist/dev/iceberg/apache-iceberg-1.4.0-rc2 >>>>> > > >>>>> > > You can find the KEYS file here: >>>>> > > * https://dist.apache.org/repos/dist/dev/iceberg/KEYS >>>>> > > >>>>> > > Convenience binary artifacts are staged on Nexus. The Maven >>>>> repository URL is: >>>>> > > * >>>>> https://repository.apache.org/content/repositories/orgapacheiceberg-1146/ >>>>> > > >>>>> > > Please download, verify, and test. >>>>> > > >>>>> > > Please vote in the next 72 hours. (Weekends excluded) >>>>> > > >>>>> > > [ ] +1 Release this as Apache Iceberg 1.4.0 >>>>> > > [ ] +0 >>>>> > > [ ] -1 Do not release this because... >>>>> > > >>>>> > > Only PMC members have binding votes, but other community members >>>>> are encouraged to cast non-binding votes. This vote will pass if there are >>>>> 3 binding +1 votes and more binding +1 votes than -1 votes. >>>>> > > >>>>> > > - Anton >>>>> > > >>>>> > >>>>> >>>> -- Ryan Blue Tabular
